Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Translate /docs navigations #149

Merged
merged 2 commits into from
Feb 26, 2019
Merged

doc: Translate /docs navigations #149

merged 2 commits into from
Feb 26, 2019

Conversation

potato4d
Copy link
Member

This PR is a part of #4

コアページの翻訳が一通り完了したため、現状で翻訳済みの範囲について nav.yml へと反映しました。

@netlify
Copy link

netlify bot commented Feb 25, 2019

Deploy preview for ja-reactjs ready!

Built with commit 20d229e

https://deploy-preview-149--ja-reactjs.netlify.com

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こうやって並べてみると整合性が悪いので変えた方がいい部分があるように思えますが(特にリファレンス周り)、とりあえずマージして、あとで修正した方がよさそうですねー

@tesseralis tesseralis mentioned this pull request Feb 25, 2019
90 tasks
@potato4d
Copy link
Member Author

そうですね、ここで編集してしまうと対応するドキュメントも編集する必要が出てきてしまうので、一旦やりきってからがよさそうです。

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koba04 koba04 merged commit ca3c264 into master Feb 26, 2019
@potato4d potato4d deleted the translate/navs branch February 26, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants